Fix #870: Lowfi Landscape HomeActivity #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2020 03:37
veena14cs
reviewed
Mar 26, 2020
| app:roundedRectDrawableWithColor="@{viewModel.backgroundColor}"> | ||
|
|
||
| <ImageView | ||
| android:id="@+id/imageView" |
veena14cs
suggested changes
Mar 26, 2020
@veena14cs all the test cases are passing. Can you please rerun them and if they fail can you post the error. |
It is passing now. May be I had some build issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #870
Mock: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/0dbdd000-6738-4f6b-9026-0d16737b7baa/HP-Home-Page-
Portrait: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/ce2a96de-2c98-41f9-91e6-6ca0d8135fb2/HP-Home-Page-Card-3-
To test this you can inject
StoryProgressTestHelperclass inHomeFragmentPresenterand use following functions one by one. Make sure to uninstall your app if you are changing functions fromStoryProgressTestHelper.First Run - Without using
StoryProgressTestHelper- you will see twoPromotedStory.Second Run - use markRecentlyPlayedForFractionsStory0Exploration0 from
StoryProgressTestHelper- you will see onePromotedStoryThird Run - use markRecentlyPlayedForFirstExplorationInAllStoriesInFractionsAndRatios from
StoryProgressTestHelper- you will see threePromotedStory.Reference code: https://gist.github.com/rt4914/5258375c8d2cca81b6a5b62ccab8e143#file-homefragmentpresenter-kt-L92 (Line 92-93)
Also, #872 issues has been filed to make sure that in future we follow some standard format for naming ids too the views. For this PR it has not been fixed as it does not harm the code in any way at the same time if we made that change it would introduce changes in more number of files.
Checklist