Fix #877: Lowfi FAQSingleActivity #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2020 22:43
nikitamarysolomanpvt
suggested changes
Mar 26, 2020
There was a problem hiding this comment.
@rt4914 Please rename FAQ to FAQs/FAQList if its focusing on more than one. for example FAQActivity,FAQFragment, Test classes, layouts, also in comments.. Please assign me back after that.
| @@ -21,10 +21,10 @@ class FAQViewModel @Inject constructor( | |||
| private fun getRecyclerViewItemList(): ArrayList<FAQItemViewModel> { | |||
| val faqHeaderViewModel = FAQHeaderViewModel() | |||
| arrayList.add(faqHeaderViewModel) | |||
|
|
|||
| val questions: Array<String> = activity.resources.getStringArray(R.array.faq_questions) | |||
There was a problem hiding this comment.
faq means its question then why we need faq_question, also faqs would be better if more than one in count.
There was a problem hiding this comment.
An FAQ is not just a question it is Question + Answer. And therefore faq_question and faq_answer
There was a problem hiding this comment.
Of-cause so that you may keep it faq and faq_answer or question and answer..
added 2 commits
March 27, 2020 00:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes: #877
Mock: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/195a7967-e7f0-4f62-a99c-8fac560e41d8/HL-FAQ-Question-Opened-current-
This PR does not deal with the correct data. The correct data will be added in #850
Checklist