Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #862: Mark chapter completed #881

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Mar 26, 2020

Explanation

Whenever an exploration is finished we need to save its progress as COMPLETED, this PR does that only.
Test cases should be added for this functionality but after having discussion with @BenHenning it was decided that we will introduced test cases for this once #495 is merged into develop. Issue for this is #880

For testing purposes you can take help from here.

  1. Uninstall the previous app.
  2. Install the latest copy of app.
  3. You will see default recommended explorations in promoted stories.
  4. Now lets finish first exploration in Fractions. Answers are mentioned below:
  • Three Fifth
  • Four Sevenths
  • Second Option
  • 2/7
  • Second Option
  • 1/6
  • 5/6
  • Second Option
  • 4/9
  • 8
  • 9
  • First and Third
  • 3/10
  • 4/6
  1. Now mark exploration as finished. Close the app. Run app again, you should see Meaning of Equal Parts as promoted story which is the second exploration in FRACTIONS.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Mar 27, 2020
@rt4914 rt4914 merged commit 7aa9a4c into develop Mar 27, 2020
@rt4914 rt4914 deleted the mark-exploration-completed-part-1 branch March 27, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants