Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #892: Highfi profile list #893

Merged
merged 5 commits into from
Mar 30, 2020
Merged

Fix #892: Highfi profile list #893

merged 5 commits into from
Mar 30, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Mar 27, 2020

Explanation

Fixes #892

Mock:

https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/ddc3dadf-10e4-45f6-aeea-eb8a330e00ff/Settings-1-Profile-1/
https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/0a5af83d-4b03-4a71-bf01-0c0a6e97e0c2/RG-MN-Register-Empty-34/

Screenshot:

Screenshot_1585313573
Screenshot_1585313575
Screenshot_1585313691
Screenshot_1585313698

Known design changes:

  • The shadow for the image view is shown to be #4D000000 in mocks but actually that was not working correctly. Now this color is exactly same to #B2B2B2 without transparency. So I used #B2B2B2 and its other transparent versions for shadow.
  • The accessibility test fails when we show Administrator string but that is fine because the Administrator string is meant to be a secondary string and we don't want learner's focus on that string.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside nit change.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Mar 30, 2020
@rt4914 rt4914 merged commit a4833fc into develop Mar 30, 2020
@rt4914 rt4914 deleted the highfi-profile-list branch March 30, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highfi ProfileListActivity
2 participants