Introduce nested data provider #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test coroutine dispatcher. This includes introducing a test-only module to contain testing dependencies.
DataProviders in a way that doesn't have the same limitations as the previous MutableLiveData-based bridge.
…w-coroutine-live-data-mechanism Conflicts: domain/src/test/java/org/oppia/domain/audio/CellularAudioDialogControllerTest.kt
DataProvider to be set up like transformAsync() but with the ability to change the root DataProvider.
…w-coroutine-live-data-mechanism
…duce-nested-data-provider
…w-coroutine-live-data-mechanism Conflicts: utility/src/main/java/org/oppia/util/data/DataProviders.kt
…duce-nested-data-provider
…w-coroutine-live-data-mechanism Conflicts: data/src/test/java/org/oppia/data/persistence/PersistentCacheStoreTest.kt
…duce-nested-data-provider
|
For future me, proposed tests that could be added (incomplete): fun testNestedXformedProvider_toLiveData_deliversTransformedValue()
fun testNestedXformedProvider_toLiveData_diffValue_notifiesNested_deliversXformedValueTwo()
fun testNestedXformedProvider_toLiveData_diffValue_notifiesBase_deliversXformedValueTwo()
fun testNestedXformedProvider_toLiveData_diffVal_notifiesXform_deliversXformedValueTwo()
fun testNestedXformedProvider_diffValue_notifiesNested_observeNested_deliversSecondVal()
fun testNestedXformedProvider_differentValue_notifiesBase_observeNested_deliversFirstVal()
fun testNestedXformedProvider_diffValue_notifiesXformed_observeNested_deliversFirstVal()
fun testNestedXformedProvider_diffValue_notifiesNested_observeBase_deliversSecondVal()
fun testNestedXformedProvider_differentValue_notifiesBase_observeBase_deliversSecondVal()
fun testNestedXformedProvider_diffValue_notifiesXformed_observeBase_deliversFirstVal()
fun testNestedXformedProvider_toLiveData_nestedPending_deliversPending()
fun testNestedXformedProvider_toLiveData_nestedFailure_deliversFailure()
fun testNestedXformedProvider_toLiveData_withObserver_callsNestedProvider()
fun testNestedXformedProvider_toLiveData_noObserver_doesNotCallNestedProvider()These are based on the transform async tests except there are some minor alterations (and overall a bunch of simplifications). Edit: actually, these are missing some tests that aren't focusing on the transform function that's passed in. These need to be updated yet. |
implementation to prepare for code review.
DataProviders tests to using TestCoroutineDispatchers utility.
…w-coroutine-live-data-mechanism
…acheStoreTest, and fix FakeSystemClock so that it works properly in test environments.
…w-coroutine-live-data-mechanism
…duce-nested-data-provider Conflicts: utility/src/main/java/org/oppia/util/data/DataProviders.kt
BenHenning
changed the title
vinitamurthi
approved these changes
May 21, 2020
aggarwalpulkit596
approved these changes
May 22, 2020
Conflicts: testing/src/main/java/org/oppia/testing/FakeSystemClock.kt
…duce-nested-data-provider
|
@aggarwalpulkit596 de-assigning you since it seems you completed your review without any follow up action items. |
Base automatically changed from
introduce-new-coroutine-live-data-mechanism
to
develop
May 28, 2020 05:53
BenHenning
changed the title
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a dynamic nested data provider. This behaves essentially the same as transformAsync, except the data provider being transformed can be changed. This is specifically needed by questions in order to handle multiple sessions (e.g. each new session involves generating another list of questions to play, and that list is subsequently transformed into the ephemeral state of the question session). See #397 for specifics.