Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #812 : Add Walkthrough Final Fragment #938

Merged
merged 4 commits into from
Apr 3, 2020
Merged

Fix #812 : Add Walkthrough Final Fragment #938

merged 4 commits into from
Apr 3, 2020

Conversation

aggarwalpulkit596
Copy link
Contributor

Explanation

Fixes #813

Mock Link: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/25ac193c-0645-4872-9e46-a408cdf2d5b7/WT-Topic-Confirmation-Unchosen-

Screenshot
Screenshot_1585811833

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

rt4914
rt4914 reviewed Apr 2, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine for now but I will do full pass once test cases are added.

@rt4914 rt4914 assigned aggarwalpulkit596 and unassigned rt4914 Apr 2, 2020
@aggarwalpulkit596
Copy link
Contributor Author

@rt4914 updated test

rt4914
rt4914 suggested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes suggested.

Also check all these test cases on a smaller device like Nexus S. As some test cases will fail on that device.

app/src/main/java/org/oppia/app/walkthrough/end/WalkthroughFinalFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/res/layout/walkthrough_final_fragment.xml Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/app/walkthrough/WalkthroughFinalFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/app/walkthrough/WalkthroughFinalFragmentTest.kt Show resolved Hide resolved
rt4914
rt4914 approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think now you can work on landscape mode for this entire WalkthroughActivity once you finish these final nit changes.

app/src/sharedTest/java/org/oppia/app/walkthrough/WalkthroughFinalFragmentTest.kt Outdated
}

@Test
fun testWalkthroughWelcomeFragment_recyclerViewIndex1_topicSelected_yesnoButton_isDisplayedCorrectly() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:
testWalkthroughWelcomeFragment_recyclerViewIndex1_topicSelected_yesNoButton_isDisplayedCorrectly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

app/src/sharedTest/java/org/oppia/app/walkthrough/WalkthroughFinalFragmentTest.kt Outdated
}

@Test
fun testWalkthroughWelcomeFragment_recyclerViewIndex1_topicSelected_noButton_worksCorrectly() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testWalkthroughWelcomeFragment_recyclerViewIndex1_topicSelected_clickNoButton_worksCorrectly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rt4914 rt4914 assigned aggarwalpulkit596 and unassigned rt4914 Apr 3, 2020
@rt4914 rt4914 merged commit 0482b00 into oppia:develop Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lowfi: WalkthroughFinalFragment - Part 3
2 participants
@aggarwalpulkit596 @rt4914