Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hifi profile chooser portrait mode #944

Merged

Conversation

nikitamarysolomanpvt
Copy link
Contributor

Explanation

This PR contain UI changes for portrait mode only with test cases.

Mock Link

https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/18e69208-8528-424a-a368-b2c5d530d235/PC-SP-Profile-Chooser-

Checklist

  • Add Administration Controls
  • App Language
  • Test cases
  • Accessibility Test

Accessibility Scanner Results

org.oppia.app:id/add_profile_text
The item's text contrast ratio is 1.53. This ratio is based on an estimated foreground color of #404040 and an estimated background color of #222222. Consider using colors that result in a contrast ratio greater than 4.50 for small text, or 3.00 for large text.
screenshot_Oppia_2020-04-06-16_09_25

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testcase are failing for me. Can you please check.
Screenshot 2020-04-07 at 10 47 41 AM

@nikitamarysolomanpvt
Copy link
Contributor Author

nikitamarysolomanpvt commented Apr 7, 2020

Testcase are failing for me. Can you please check.
Screenshot 2020-04-07 at 10 47 41 AM

@veena14cs i was also facing same issue i did invalidate and clear caches then it was passing. Please try and let me know

@veena14cs
Copy link
Contributor

Testcase are failing for me. Can you please check.
Screenshot 2020-04-07 at 10 47 41 AM

@veena14cs i was also facing same issue i did invalidate and clear caches then it was passing. Please try and let me know

Now its passing after doing that.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nikitamarysolomanpvt nikitamarysolomanpvt merged commit 4e0a346 into develop Apr 7, 2020
@nikitamarysolomanpvt nikitamarysolomanpvt deleted the high-fi-profile-selection-portrait-mode branch April 7, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants