-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generated_by attribute to page.file #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I suppose the src_path
attributes are untruthful coming from mkdocs-gen-files.
Perhaps un-setting the src_path
would be the cooler solution, but it's also likely to break something else.
So, nice.
Can you give me a pointer on how to solve the style error?
|
Fixed it.. after a bit of search I released it was a mypy error (I'm not familiar with hatch), |
This time it was p.s. A small section on 'contributing' and how to run the hatch commands would be a nice addition :) |
Hi @oprypin , any blockers to merging this PR? Seems ready to go :) |
I'm interested in this as well (would like to to use mkdocs-git-revision-date-localized-plugin 😉). Let me know if I can be of any help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
And released. Sorry for the huge delay. |
Sorry for necroposting, but could we add |
This PR adds an attribute to generated files.
Currently,
mkdocs-gen-files
andmkdocs-git-revision-date-localized-plugin
are incompatible.Using this new attribute, this PR can add support: timvink/mkdocs-git-revision-date-localized-plugin#102
More details in timvink/mkdocs-git-revision-date-localized-plugin#101