Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a delay for a service to be present in the remote test container before installing the test probe #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lanouettea
Copy link

This modification can allow specific scenarios where a specialized
service is registered to indicate that the framework is ready for the
test. This can be especially useful for tests using blueprint or test
using bundles that load other bundles in the container without being
explicitely in the boot features defined by the pax exam test.

…r before installing the test probe

This modification can allow specific scenarios where a specialized
service is registered to indicate that the framework is ready for the
test. This can be especially useful for tests using blueprint or test
using bundles that load other bundles in the container without being
explicitely in the boot features defined by the pax exam test.
@ANierbeck
Copy link
Member

ANierbeck commented Apr 20, 2016

Hi,

first of all thanks for providing a pull request. Now let's get down to business. Could you please take a look at the Contributing section of the README.md
Therefore following is needed prior merging this pull-request:

  • Describe your problem or enhancement request before submitting a solution.
  • Submit a JIRA issue before creating a pull request. This is required for the release notes.
  • For discussions, the mailing list is more suitable than JIRA.
  • Any bugfix or new feature must be covered by regression tests.
  • Respect the coding style and formatting conventions of existing sources. There is an Eclipse formatter in assets/EclipseJavaFormatter.xml.

Regarding the last point, in this fix the imports do look like they violate that.
Regarding the commits, those should be squashed, especially since you provided two where the second fixed an issue of the first.

@lanouettea
Copy link
Author

Thank you for the feedback Achim.

Apparently, my IDE (IntelliJ) has rearranged import and reformatted the code. I believed I fixed those scrambles before commiting. I will review everything and submit a new commit with correct code formatting and a valid test case.

Do you have an intelliJ formatter available as well?

@ANierbeck
Copy link
Member

Hi,

I'm not aware of a intelliJ formating file, feel free to do a pull request for that also :)

regards, Achim


/**
* Per default the folder pax-exam is deleting the test directories after a test is over. If you want to keep those
* directories (for later evaluation) simply set this option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this JavaDoc seems to be copy-pasted from another option, and should be adjusted to described this new option instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants