Let the user set the chunk-size for CPU limit enforcement #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a large chunk-size, the cpulimit command adds very little overhead, but the CPU usage of the limited process may vary wildly from moment to moment. With a small chunk-size, the cpulimit command can add significant overhead, but the CPU usage of the limited process stays very close to the requested value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to run an old video-game that used a busy-wait for proper timing, but I didn't want to spend gigahertz on a process designed for megahertz. I found your cpulimit tool, and it was almost what I wanted: it slowed things down nicely, but the default chunk-size of 100ms was too much. I could visibly see the game run a little bit, then pause, then run a little bit and pause again.
With this patch, I'm running my game with a chunk-size of 16ms, or about one frame at my monitor's 60Hz refresh rate, and it works beautifully.