Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic infrastructure for type checking #496

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Basic infrastructure for type checking #496

merged 2 commits into from
Jul 10, 2024

Conversation

janosg
Copy link
Member

@janosg janosg commented May 3, 2024 •
edited
Loading

Add basic infrastructure for type checking.

@janosg janosg added enhancement New feature or request WIP Work in progress labels May 3, 2024
@codecov Codecov
Copy link

codecov bot commented May 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/estimagic/algorithms.py 100.00% <ø> (ø)
src/estimagic/parameters/conversion.py 95.96% <100.00%> (ø)
src/estimagic/parameters/scale_conversion.py 93.22% <100.00%> (ø)
src/estimagic/parameters/space_conversion.py 97.45% <100.00%> (ø)
src/estimagic/parameters/tree_conversion.py 89.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

@janosg janosg changed the title Implementation of EEP-02: Static typing [WIP] Basic infrastructure for type checking Jul 10, 2024
@janosg janosg requested a review from timmens July 10, 2024 09:28
@janosg janosg removed the WIP Work in progress label Jul 10, 2024
hmgaudecker
hmgaudecker approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@janosg janosg merged commit 2ab9ac5 into main Jul 10, 2024
15 checks passed
@janosg janosg deleted the typing branch July 10, 2024 09:54
@janosg janosg removed the request for review from timmens July 10, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmgaudecker hmgaudecker hmgaudecker approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janosg @hmgaudecker