small changes to explanation files in documentation #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ChristianZimpelmann. I will merge my current PR first, which should fix the tests. Then I'll have a look. I like your suggestion for more interactive plots but I am not sure we will have time to implement it anytime soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
janosg
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the minor changes which I already implemented:
explanation_of_numerical_optimizers.md. However, it would be great if there was a way to manually click through the images such that the user can speed it up or revert to a previous figure. With the current implementation via gifs it takes quite a while to see the full cycle.