Content storage #14
Merged
Content storage #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrapeBaBa
reviewed
Dec 12, 2023
| @@ -62,6 +64,16 @@ const ( | |||
| PersistOfferRequestKind byte = 0x02 | |||
| ) | |||
|
|
|||
| var ErrNilContentKey = errors.New("content key cannot be nil") | |||
There was a problem hiding this comment.
shouldn't these all be moved to content_storage.go?
There was a problem hiding this comment.
this err is return from the PortalProtocol before call the content_storage, so this should be in PortalProtocol
GrapeBaBa
reviewed
Dec 12, 2023
|
|
||
| contentQueue chan *ContentElement | ||
| } | ||
|
|
||
| func NewPortalProtocol(config *PortalProtocolConfig, protocolId string, privateKey *ecdsa.PrivateKey, storage Storage, contentQueue chan *ContentElement) (*PortalProtocol, error) { | ||
| func defaultContentIdFunc(contentKey []byte) []byte { |
There was a problem hiding this comment.
this should be in PortalProtocol, storage do not care about the contentKey to contentId
GrapeBaBa
reviewed
Dec 12, 2023
| args[i] = id | ||
| } | ||
|
|
||
| // 执行删除操作 |
GrapeBaBa
reviewed
Dec 12, 2023
| return res | ||
| } | ||
|
|
||
| func defaultContentIdFunc(contentKey []byte) []byte { |
There was a problem hiding this comment.
yes, I will delete it, the content storage not care about how the contentKey tranform to contentId
GrapeBaBa
reviewed
Dec 12, 2023
| maxDistance = uint256.MustFromHex("0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff") | ||
| ) | ||
|
|
||
| const ( |
GrapeBaBa
reviewed
Dec 12, 2023
| ORDER BY distance DESC` | ||
| ) | ||
|
|
||
| type ContentStorage struct { |
There was a problem hiding this comment.
public method comments not follow go standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl content storage #9