forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal Storage #9
Closed
Closed
Commits on Dec 11, 2023
-
all: replace log15 with slog (ethereum#28187)
This PR replaces Geth's logger package (a fork of [log15](https://github.com/inconshreveable/log15)) with an implementation using slog, a logging library included as part of the Go standard library as of Go1.21. Main changes are as follows: * removes any log handlers that were unused in the Geth codebase. * Json, logfmt, and terminal formatters are now slog handlers. * Verbosity level constants are changed to match slog constant values. Internal translation is done to make this opaque to the user and backwards compatible with existing `--verbosity` and `--vmodule` options. * `--log.backtraceat` and `--log.debug` are removed. The external-facing API is largely the same as the existing Geth logger. Logger method signatures remain unchanged. A small semantic difference is that a `Handler` can only be set once per `Logger` and not changed dynamically. This just means that a new logger must be instantiated every time the handler of the root logger is changed. ---- For users of the `go-ethereum/log` module. If you were using this module for your own project, you will need to change the initialization. If you previously did ```golang log.Root().SetHandler(log.LvlFilterHandler(log.LvlInfo, log.StreamHandler(os.Stderr, log.TerminalFormat(true)))) ``` You now instead need to do ```golang log.SetDefault(log.NewLogger(log.NewTerminalHandlerWithLevel(os.Stderr, log.LevelInfo, true))) ``` See more about reasoning here: ethereum#28558 (comment)
Configuration menu - View commit details
-
Copy full SHA for a00303e - Browse repository at this point
Copy the full SHA a00303eView commit details -
Configuration menu - View commit details
-
Copy full SHA for acbae3f - Browse repository at this point
Copy the full SHA acbae3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b50cd - Browse repository at this point
Copy the full SHA 65b50cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a3b2a9 - Browse repository at this point
Copy the full SHA 2a3b2a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00e7a40 - Browse repository at this point
Copy the full SHA 00e7a40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 460556f - Browse repository at this point
Copy the full SHA 460556fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94b2445 - Browse repository at this point
Copy the full SHA 94b2445View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95dc162 - Browse repository at this point
Copy the full SHA 95dc162View commit details -
Configuration menu - View commit details
-
Copy full SHA for db9a87c - Browse repository at this point
Copy the full SHA db9a87cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 493a17d - Browse repository at this point
Copy the full SHA 493a17dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.