Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9410] feat(allowed hosts): Added support to remove sdkKey from logs. #329

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • sdkKey can be removed from logs by setting log.includeSdkKey configuration property to false.

reqID := r.Header.Get(OptlyRequestHeader)
logger := log.With().Str("requestId", reqID).Logger()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bring it after if, stay with the same sequence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain marked this pull request as ready for review January 24, 2022 22:30
@msohailhussain msohailhussain merged commit 04b8b18 into master Feb 10, 2022
@msohailhussain msohailhussain deleted the yasir/sdkkeyLogging branch February 10, 2022 06:05
@russell-loube-optimizely russell-loube-optimizely changed the title feat(allowed hosts): Added support to remove sdkKey from logs. [FSSDK-9410] feat(allowed hosts): Added support to remove sdkKey from logs. May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants