Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-8837] Implement API for sendOdpEvent in Agent #356

Merged
merged 15 commits into from
Mar 7, 2023
Merged

[FSSDK-8837] Implement API for sendOdpEvent in Agent #356

merged 15 commits into from
Mar 7, 2023

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Feb 24, 2023 •
edited
Loading

Summary

  • Implement API for sendOdpEvent, update open api schema. Extend agent config to include odp.
  • extend config to accommodate ODP
  • update open API schema
  • unit tests

Issues

@Mat001 Mat001 self-assigned this Feb 24, 2023
@Mat001 Mat001 changed the title [FSSDK-8837] Add ODP wrapper [FSSDK-8837] Extend Agent with ODP wrapper functionality Feb 25, 2023
@Mat001 Mat001 changed the title [FSSDK-8837] Extend Agent with ODP wrapper functionality [FSSDK-8837] Extend Agent with ODP functionality Feb 25, 2023
@Mat001 Mat001 changed the title [FSSDK-8837] Extend Agent with ODP functionality [FSSDK-8837] Implement API for sendOdpEvent in Agent Mar 4, 2023
jaeopt
jaeopt requested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few changes suggested.

api/openapi-spec/openapi.yaml Outdated Show resolved Hide resolved
pkg/handlers/decide.go Outdated Show resolved Hide resolved
pkg/handlers/send_odp_event.go Outdated Show resolved Hide resolved
pkg/handlers/send_odp_event.go Outdated Show resolved Hide resolved
pkg/handlers/send_odp_event.go Outdated Show resolved Hide resolved
pkg/handlers/send_odp_event.go Show resolved Hide resolved
@Mat001 Mat001 requested a review from jaeopt March 7, 2023 19:16
yasirfolio3
yasirfolio3 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor change suggested, looks good overall.

pkg/optimizely/optimizelytest/client.go Outdated Show resolved Hide resolved
jaeopt
jaeopt approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/handlers/send_odp_event.go Show resolved Hide resolved
@Mat001 Mat001 merged commit e2f365c into master Mar 7, 2023
@Mat001 Mat001 deleted the mpirnovar-odp branch March 7, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@yasirfolio3 yasirfolio3 yasirfolio3 approved these changes

@andrewleap-optimizely andrewleap-optimizely Awaiting requested review from andrewleap-optimizely

Assignees

@Mat001 Mat001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mat001 @yasirfolio3 @jaeopt