-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-10553] add IsEveryoneElseVariation marker in decide API #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the Jira on this, but 2 initial thoughts:
- Should this be solved in the SDK or via project configuration, as you mentioned as a variation?
- If this is something that an SDK should handle, then perhaps it needs to be put in all the base language SDKs.
There's a high probability you've already run through all these thoughts, and I'm late to understanding.
I do not see any problems with the coded solution, but will refrain from providing Approval since I'm not fully knowledgeable on the problem.
cc @jaeopt
Hey @mikechu-optimizely
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mikechu-optimizely @pulak-opti |
Summary
Ticket