Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10762] Implement UPS request batching for decideForKeys #549

Merged
merged 24 commits into from
Oct 22, 2024
Merged

[FSSDK-10762] Implement UPS request batching for decideForKeys #549

merged 24 commits into from
Oct 22, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • Currently, decideForKeys loops over the list of flags and calls decide for each, which in turn calls ups. So for decideForKeys, there is two calls per flag to UPS. This PR batches UPS calls when using decideForKeys.

Test plan

  • existing tests are updated to work with the new change. New tests will be added for batching.

Issues

  • FSSDK-10762

@raju-opti raju-opti requested a review from a team as a code owner October 18, 2024 14:31
@raju-opti raju-opti requested a review from jaeopt October 18, 2024 14:31
jaeopt
jaeopt requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few comments added.

core-api/src/main/java/com/optimizely/ab/Optimizely.java Outdated Show resolved Hide resolved
core-api/src/main/java/com/optimizely/ab/Optimizely.java Show resolved Hide resolved
core-api/src/main/java/com/optimizely/ab/Optimizely.java Outdated Show resolved Hide resolved
core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java Outdated Show resolved Hide resolved
core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java Outdated Show resolved Hide resolved
core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java Outdated Show resolved Hide resolved
@raju-opti raju-opti requested a review from jaeopt October 22, 2024 13:39
jaeopt
jaeopt approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit fe50318 into master Oct 22, 2024
16 checks passed
@raju-opti raju-opti deleted the raju/ups branch October 22, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely left review comments

@jaeopt jaeopt jaeopt approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @jaeopt @mikechu-optimizely