Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log-level) change single audience result to debug #496

Merged
merged 3 commits into from
Jun 5, 2020

Conversation

fayyazarshad
Copy link
Contributor

@fayyazarshad fayyazarshad commented May 29, 2020

Summary

Updating audience evaluation log level to be debug. The only info level log will be the one corresponding to the result of overall evaluation of an audience.

Test plan

All checks pass.

@fayyazarshad fayyazarshad requested a review from a team as a code owner May 29, 2020 07:06
@coveralls
Copy link

coveralls commented May 29, 2020

Coverage Status

Coverage remained the same at 96.768% when pulling 3c18d1c on fayyaz/update_log_level into 95cd8a0 on master.

@mjc1283
Copy link
Contributor

mjc1283 commented May 29, 2020

@fayyazarshad Could you add an entry in CHANGELOG.md?

@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [4.0.0] - April 30, 2020

### Bug fixes
Revisited audience evaluation log level to debug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong place - please add it under [Unreleased]

@fayyazarshad fayyazarshad force-pushed the fayyaz/update_log_level branch from 0b6a91a to 3c18d1c Compare May 29, 2020 16:54
@fayyazarshad fayyazarshad removed their assignment May 29, 2020
@mjc1283 mjc1283 merged commit 81269aa into master Jun 5, 2020
@mjc1283 mjc1283 deleted the fayyaz/update_log_level branch June 5, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants