fix(logs): Fixing log messages for Targeted Rollouts #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
changed the title
oakbani
reviewed
Jul 1, 2020
oakbani
previously requested changes
Jul 1, 2020
There was a problem hiding this comment.
- Please remove additional logs from getVariationForFeature. See Python PR for reference. getVariation is internally called which already logs when if variation exists or doesn't.
- Do we have any unit tests for rollout rule evaluation logs? We should add some so that we assert that we are logging as expected.
|
Resolved feedback from Owais, @zashraf1985 can you please have a look? |
fayyazarshad
force-pushed
the
fayyaz/update_logs_for_tr
branch
from
63dd5a6 to
0ca7e42
Compare
|
get_feature_variable_json tests of FSC are failing, due to its name is changed in #516 which is not merged yet but testapp PR is merged with the updated name |
fayyazarshad
force-pushed
the
fayyaz/update_logs_for_tr
branch
from
f0059c3 to
fcf75fb
Compare
fayyazarshad
changed the title
fayyazarshad
changed the title
fayyazarshad
force-pushed
the
fayyaz/update_logs_for_tr
branch
from
940f462 to
b00249b
Compare
fayyazarshad
changed the title
fayyazarshad
force-pushed
the
fayyaz/update_logs_for_tr
branch
from
cf7d09a to
720f2bf
Compare
mjc1283
suggested changes
Jul 23, 2020
mjc1283
suggested changes
Jul 24, 2020
mjc1283
approved these changes
Jul 24, 2020
aliabbasrizvi
approved these changes
Jul 24, 2020
|
@oakbani dismissing your review to be able to merge. |
aliabbasrizvi
dismissed
oakbani’s stale review
Dismissing since the feedback was addressed.
mjc1283
added a commit
that referenced
this pull request
Aug 10, 2020
…nto a traffic allocation range with empty string entityId (#549) Summary: Fix an issue introduced in #515. When bucket returns empty string, we shouldn't log a warning about invalid variation ID. Empty string is a valid value for the entityId property of traffic allocation range objects. There is no invalid variation ID in this situation. Test plan: Manually tested with A/B tests and rollouts. Added new unit test. Issues: OASIS-6890
mjc1283
added a commit
that referenced
this pull request
Aug 10, 2020
…nto a traffic allocation range with empty string entityId (#549) Summary: Fix an issue introduced in #515. When bucket returns empty string, we shouldn't log a warning about invalid variation ID. Empty string is a valid value for the entityId property of traffic allocation range objects. There is no invalid variation ID in this situation. Test plan: Manually tested with A/B tests and rollouts. Added new unit test. Issues: OASIS-6890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this change we are introducing targeted rollout specific log messages.
Test plan
All Unit and FSC Tests are getting passed