Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10180] close http request after getting response to release memory immediately (node) #927

Merged
merged 2 commits into from
May 13, 2024
Merged

[FSSDK-10180] close http request after getting response to release memory immediately (node) #927

merged 2 commits into from
May 13, 2024

Conversation

pulak-opti
Copy link
Contributor

@pulak-opti pulak-opti commented May 9, 2024 •
edited
Loading

Summary

  • close req after getting response to release memory immediately (node)

Test plan

Existing tests should pass

Issues

@pulak-opti pulak-opti changed the title [FSSDK-10180] immediately close req and release memory after http call (node) [FSSDK-10180] close req after getting response to release memory immediately (node) May 9, 2024
@pulak-opti pulak-opti changed the title [FSSDK-10180] close req after getting response to release memory immediately (node) [FSSDK-10180] close http request after getting response to release memory immediately (node) May 9, 2024
@coveralls
Copy link

coveralls commented May 9, 2024 •
edited
Loading

Coverage Status

coverage: 90.308% (-0.005%) from 90.313%
when pulling 9d62b41 on pulak/improve-memo-mgmt
into 75418da on master.

@mikechu-optimizely
Copy link
Contributor

We'll definitely want to test in a browser, lite, & react native context.

@pulak-opti pulak-opti marked this pull request as ready for review May 10, 2024 16:33
@pulak-opti pulak-opti requested a review from a team as a code owner May 10, 2024 16:33
mikechu-optimizely
mikechu-optimizely approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions below 👇 , but nothing blocking moving forward. Good research. Thanks. 👍

lib/plugins/event_dispatcher/index.node.ts Show resolved Hide resolved
lib/plugins/event_dispatcher/index.node.ts Outdated Show resolved Hide resolved
lib/plugins/event_dispatcher/index.node.ts Outdated Show resolved Hide resolved
mikechu-optimizely
mikechu-optimizely approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pulak-opti pulak-opti merged commit 34496f2 into master May 13, 2024
15 of 20 checks passed
@pulak-opti pulak-opti deleted the pulak/improve-memo-mgmt branch May 13, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@pulak-opti pulak-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pulak-opti @coveralls @mikechu-optimizely