Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9022] Dev Containers and bug bash #269

Merged
merged 44 commits into from
Jun 26, 2023
Merged

[FSSDK-9022] Dev Containers and bug bash #269

merged 44 commits into from
Jun 26, 2023

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Jun 9, 2023

Summary

  • Updating php-sdk to be compatible with php version 8.2

Test plan

  • unit tests passing
    • FSC tests passing
    • bug bash passing

Issues

https://jira.sso.episerver.net/browse/FSSDK-9022
https://jira.sso.episerver.net/browse/FSSDK-9073
https://jira.sso.episerver.net/browse/FSSDK-9071
https://jira.sso.episerver.net/browse/FSSDK-9072

@coveralls
Copy link

coveralls commented Jun 9, 2023

Coverage Status

coverage: 97.333%. remained the same when pulling 3810ed3 on mike/bug-bash-php8 into e197aa4 on master.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely changed the title Mike/bug bash php8 [FSSDK-9022] Dev Containers and bug bash Jun 26, 2023
@mikechu-optimizely
Copy link
Contributor

@Mat001 Feel free to squash and merge when ready.

@Mat001 Mat001 merged commit 04f5c20 into master Jun 26, 2023
7 checks passed
@Mat001 Mat001 deleted the mike/bug-bash-php8 branch June 26, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants