Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9494] Bug bash & fixes #214

Merged
merged 77 commits into from
Sep 22, 2023
Merged

[FSSDK-9494] Bug bash & fixes #214

merged 77 commits into from
Sep 22, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Sep 21, 2023

Summary

  • Add manual testing (bug bash) resources & Vite app
  • Fix some of the resulting discovered issues

💡 Note: There are a lot of files, but mostly need review of things outside the /bug-bash/ dir.

Test plan

  • All automated testing should continue to pass.

Issues

  • FSSDK-9494

src/client.ts Show resolved Hide resolved
Mike Chu added 3 commits September 22, 2023 14:11
WIP Fix tests that fail if dataReadyPromise resolves success=false
src/client.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikechu-optimizely mikechu-optimizely merged commit 20cc6cc into master Sep 22, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/bug-bash branch September 22, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants