Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10120] setForcedDecision does not reflects in Optimizely client instance #274

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

junaed-optimizely
Copy link
Contributor

Summary

Test plan

  • As we are mocking the inner client, there is no way to add test cases for this specific use case right now. However there is a dedicated ticket FSSDK-10439 to improve the "Optimizely client" test coverage. Improvement should be expected from there.

Issues

FSSDK-10120

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as our per our collab DMs

@junaed-optimizely junaed-optimizely merged commit 023d301 into master Aug 15, 2024
9 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10120-set-forced-decision-bug branch August 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants