Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2.1] Prep for release #275

Merged
merged 2 commits into from
Aug 15, 2024
Merged

[3.2.1] Prep for release #275

merged 2 commits into from
Aug 15, 2024

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Aug 15, 2024 •
edited
Loading

Summary

Bug fixes

  • clientReady is true even though internal client promise returns success == false bug fix
  • useDecision hook set the update listener on overy render bug fix
  • setForcedDecision does not reflect the changes in optmizely instance and useDecision hook bug fix

Changed

  • Performance improvements in both hooks and client instance

Test plan

Existing test should pass

Issues

mikechu-optimizely
mikechu-optimizely requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
mikechu-optimizely
mikechu-optimizely approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🙏

@junaed-optimizely junaed-optimizely merged commit c16ea02 into master Aug 15, 2024
9 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/prep-3.2.1 branch August 15, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@junaed-optimizely junaed-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junaed-optimizely @mikechu-optimizely