Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10880] override initial user bug adjustment #292

Merged

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Nov 7, 2024

Summary

After upgrading to v3 of the Optimizely React SDK, rendering the OptimizelyProvider after calling setUser resets the user to a default one unless explicitly provided via the user prop.

Test plan

Existing tests have been adjusted accordingly.

Issues

Copy link

github-actions bot commented Nov 7, 2024

Jest Coverage Report

St.
Category Percentage Covered / Total
🟢 Statements
98.95% (+0% 🔼)
849/858
🟢 Branches
91.44% (-0.16% 🔻)
342/374
🟢 Functions 97.52% 157/161
🟢 Lines
99.1% (+0% 🔼)
767/774
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 Provider.tsx 100%
90.63% (-1.97% 🔻)
100% 100%

Test suite run success

265 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from 382692e

@junaed-optimizely junaed-optimizely marked this pull request as ready for review November 7, 2024 14:27
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junaed-optimizely junaed-optimizely merged commit fcedfe9 into master Nov 7, 2024
14 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10880-provider-override-user-bug branch November 7, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants