Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10121] doc update #295

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

junaed-optimizely
Copy link
Contributor

Summary

Doc only update with more instructions for "React Native"

Test plan

Existing test should pass

Issues

Copy link

github-actions bot commented Nov 15, 2024

Jest Coverage Report

St.
Category Percentage Covered / Total
🟢 Statements 98.95% 849/858
🟢 Branches 91.44% 342/374
🟢 Functions 97.52% 157/161
🟢 Lines 99.1% 767/774

Test suite run success

265 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from 7ad29c8

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for helping Exo devs.

@junaed-optimizely junaed-optimizely merged commit 2ddb3c3 into master Nov 15, 2024
13 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10121-expo-poc-doc branch November 15, 2024 14:16
@mikechu-optimizely
Copy link
Contributor

You may want to add the Topic optimizely-environment-public and an About description to the optimizely/expo-react-native-sdk-sample repo. Maybe steal from optimizely/aws-lambda-at-edge-starter-kit 🤔

@junaed-optimizely
Copy link
Contributor Author

You may want to add the Topic optimizely-environment-public and an About description to the optimizely/expo-react-native-sdk-sample repo. Maybe steal from optimizely/aws-lambda-at-edge-starter-kit 🤔

Ok. Thanks for the advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants