Implement get_feature_variable and create unit tests #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into brandon/get_feat_var
brandonhudavid
changed the title
There was a problem hiding this comment.
Mostly looks ok, just have a small comment. @msohailhussain can you also take a look when you get the chance please
| @@ -132,6 +132,15 @@ def inputs_valid?(variables, logger = NoOpLogger.new, level = Logger::ERROR) | |||
| variables.delete :user_id | |||
| end | |||
|
|
|||
| if variables.include? :variable_type | |||
| # Empty variable_type is a valid user ID. | |||
There was a problem hiding this comment.
huh? This can you explain this?
There was a problem hiding this comment.
If variables[:variable_type] is anything other than a String or null value, it is invalid. Otherwise, it is valid, and so we remove variable_type from variables. That way, it does not go through the value.is_a?(String) && !value.empty? check on line 145.
|
@brandonhudavid Can you please resolve lint errors. |
mikeproeng37
suggested changes
Jul 30, 2019
This was referenced Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_feature_variablemethod inoptimizely.rbto return value of variable with any typeinputs_valid?function invalidator.rbto allow fornilvariable typeproject_spec.rbto ensure functionality ofget_feature_variableRuby is a dynamically-typed language, like JavaScript, so it suffices to have a single method return the value of a feature variable rather than have a separate method for each possible feature variable type.
Test plan
project_spec.rbIssues