Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ODP GraphQLApi interface #308

Merged
merged 6 commits into from
Aug 9, 2022
Merged

feat: add ODP GraphQLApi interface #308

merged 6 commits into from
Aug 9, 2022

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

Provides an internal service for ODP graphQL server access.

  • Supports fetching segments from the ODP server.

Tests

Added:

  • zaius_graphql_api_manager_spec.rb

Ticket

OASIS-8434

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review August 8, 2022 14:55
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner August 8, 2022 14:55
jaeopt
jaeopt requested changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A couple of small changes suggested.

lib/optimizely/odp/zaius_graphql_api_manager.rb Outdated Show resolved Hide resolved
spec/odp/zaius_graphql_api_manager_spec.rb Show resolved Hide resolved
lib/optimizely/odp/zaius_graphql_api_manager.rb Outdated Show resolved Hide resolved
spec/odp/zaius_graphql_api_manager_spec.rb Outdated Show resolved Hide resolved
jaeopt
jaeopt approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit 5a2ae4e into master Aug 9, 2022
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/add_graphql_api branch August 9, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @zashraf1985 @jaeopt