Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rest api manager #311

Merged
merged 5 commits into from
Aug 19, 2022
Merged

feat: add rest api manager #311

merged 5 commits into from
Aug 19, 2022

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

Provide an internal service for sending ODP events via REST api.

  • When dispatch is completed successfully, no action is required.
  • Returns should_retry bool to allow retries on network/server errors

Test plan

  • added zaius_rest_api_manager_spec.rb

Ticket

OASIS-8450

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review August 18, 2022 14:28
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner August 18, 2022 14:28
jaeopt
jaeopt requested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of clarifications.

lib/optimizely/odp/zaius_rest_api_manager.rb Outdated Show resolved Hide resolved
lib/optimizely/odp/zaius_rest_api_manager.rb Outdated Show resolved Hide resolved
jaeopt
jaeopt approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zashraf1985
zashraf1985 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@andrewleap-optimizely andrewleap-optimizely merged commit c574289 into master Aug 19, 2022
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/add_rest_api_manager branch August 19, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @zashraf1985 @jaeopt