chore: removed travis yml and added git action support #454

yasirfolio3 · 2022-04-14T06:00:09Z

Summary

We remove travis yaml from swift-sdk and moved all the stages to git action.
Not tested release and pre-release sections.

Test plan

All tests should pass

Result

https://github.com/optimizely/swift-sdk/runs/6074478472?check_suite_focus=true

NOTE

Need to update branch name to master before merging in the following places.
first, second, third, fourth

coveralls · 2022-04-14T06:36:21Z

Coverage remained the same at 95.687% when pulling 6b83858 on yasir/gitAction into 193cc00 on master.

msohailhussain · 2022-04-19T22:19:19Z

.github/workflows/integration_tests.yml

+        echo "SDK_BRANCH=${{ github.ref_name }}" >> $GITHUB_ENV
+        echo "TRAVIS_BRANCH=${{ github.ref_name }}" >> $GITHUB_ENV


these variables doesn't seem correct to set with refname.

ref_name has the The branch or tag name that triggered the workflow run. as per the official documentation, in case build was not triggered by pull request. This is required by travisci-tools/trigger-script-with-status-update.sh.

remove it, we don't have any relation with the current repo to trigger-script-with-status-update.sh

msohailhussain · 2022-04-19T22:26:11Z

.github/workflows/integration_tests.yml

+        RELEASE: ${{ secrets.RELEASE }}
+      if: "${{ env.PREP == '' && env.RELEASE == '' }}"
+      run: |
+        echo "$GITHUB_CONTEXT"


no need of it.

jaeopt

I see all the previous issue cleaned up. I have a few more suggestions.

jaeopt · 2022-04-22T21:29:25Z

Scripts/run_prep.sh

+#!/bin/bash -e
 set -e


Do we need both "bash -e" and "set -e"?

jaeopt · 2022-04-22T22:48:04Z

.github/workflows/swift.yml

+        xcode-version: '12.4'
+    - name: Push to cocoapods.org
+      env:
+        VERSION: 3.10.1


This SDK version may be confusing - one for "prepare-for-release" is defined in the workflow-call and the same for "release" is defined in this top level.
It'll be great if we can find a way to share a single variable at the top level and pass it to "prepare-for-release" as a parameter.

jaeopt · 2022-04-22T22:49:11Z

.github/workflows/swift.yml

+      env:
+        VERSION: 3.10.1
+        GITHUB_TOKEN: ${{ secrets.CI_USER_TOKEN }}
+        TRAVIS_BRANCH: ${{ github.ref_name }}


Do we still use "TRAVIS" in the names? :)

Removed all env variables with previs TRAVIS_ leaving only those which are required by trigger-script-with-status-update script of travis-ci-tools.

jaeopt · 2022-04-22T22:50:50Z

.github/workflows/prepare_for_release.yml

+    - id: prepare_for_release
+      name: Prepare for release
+      env:
+        VERSION: 3.10.1


This value (SDK release version) should be passed as a parameter from the top level

I looked into it and have tried to make it a global env. For using reusable_workflows, we cannot pass env variables to them. Because of this, version is declared twice in swift.yml.

jaeopt · 2022-04-22T23:08:37Z

Scripts/prepare_simulator.sh

+    # Link and create simulators from older xcode versions which are not part of the current xcode version
+    sudo ln -s /Applications/Xcode_$SIMULATOR_XCODE_VERSION.app/Contents/Developer/Platforms/$os_folder/CoreSimulator/Profiles/Runtimes/$OS_TYPE.simruntime /Library/Developer/CoreSimulator/Profiles/Runtimes/$OS_TYPE\ $OS.simruntime
+    xcrun simctl create "custom-device" "com.apple.CoreSimulator.SimDeviceType.$name" "com.apple.CoreSimulator.SimRuntime.$OS_TYPE-$os"
+    CUSTOM_SIMULATOR="$(instruments -s devices | grep -m 1 'custom-device' | awk -F'[][]' '{print $2}')"
+else
+    echo ".devices.\"com.apple.CoreSimulator.SimRuntime.${PLATFORM/ Simulator/}-${OS/./-}\"" > /tmp/jq_file
+    CUSTOM_SIMULATOR=$( xcrun simctl list --json devices | jq -f /tmp/jq_file | jq -r '.[] | select(.name==env.NAME) | .udid' )
+fi


It looks like you spent a lot of efforts to figure out all these mappings :) Not a good support from github. I'm concerned if we need to adjust the versions and paths whenever Apple releases new iOS versions.

Since we are using runs-on: macos-10.15, these values will not change. Simulators and xcode versions are released along with macos versions by git actions. If we intend to move to newer versions of simulators, we would just need to update the runs-on: value and update the simulator versions as per the new documentation in unit_tests.yml.

jaeopt

Looks great! One last change we can consider.

yasirfolio3 · 2022-04-26T05:21:25Z

Looks great! One last change we can consider.

Hey @jaeopt , i am unable to see the change request 👍

jaeopt

I don't know what happened to my prev comments :) Here we go again.

jaeopt · 2022-04-26T16:05:36Z

.github/workflows/swift.yml

@@ -53,7 +53,7 @@ jobs:
    if: "${{ github.event.inputs.PREP == 'true' && github.event_name == 'workflow_dispatch' }}" 
    uses: optimizely/swift-sdk/.github/workflows/prepare_for_release.yml@yasir/gitAction
    with:
-      VERSION: ${{ env.VERSION }}
+      VERSION: 3.10.1 # env variables cannot be used for reusable workflows


I now see the limitation of sharing var. I wonder if we can bring "prepare_for_release" back to "swift.yml" and share a single VERSION for both "release" and "prepare_for_release". Any reason we keep only one of them in the separate workflow?

jaeopt

LGTM

msohailhussain

lgtm

yasirfolio3 and others added 3 commits April 13, 2022 13:50

Initial commit

8ad3ace

Work in progress.

0671c23

WIP.

ba4bc67

yasirfolio3 added the wip label Apr 14, 2022

yasirfolio3 added 2 commits April 14, 2022 14:06

Implementing git action.

f938fea

fixes.

2589339

yasirfolio3 force-pushed the yasir/gitAction branch from 874565f to 2589339 Compare April 14, 2022 09:24

yasirfolio3 added 6 commits April 14, 2022 14:47

fixes.

62d7d3f

fixes.

cfc07ba

fixes.

f0f47f3

fixes.

fe68edf

fixes.

37cd6a9

fixes.

5525d2a

yasirfolio3 closed this Apr 14, 2022

yasirfolio3 reopened this Apr 14, 2022

yasirfolio3 added 14 commits April 14, 2022 17:47

fixes.

ea18040

fixes

bf81c48

fixes

35cfa3a

fixes.

d199827

fixes

640a68b

fixes

41bd868

fixes.

6b8a79a

fixes

c9e5de6

fixes

17f3db7

fixes

3855e80

fixes

7b7ba15

fixes

e1d6175

checking directory structure.

8d6642d

fixes.

1d75400

msohailhussain reviewed Apr 19, 2022

View reviewed changes

Suggested changes made.

39b7edd

yasirfolio3 force-pushed the yasir/gitAction branch 2 times, most recently from ee964ca to 39b7edd Compare April 20, 2022 11:06

yasirfolio3 added 7 commits April 20, 2022 16:17

fix coveralls.

f0e90c6

Testing coveralls.

c97248d

testing coveralls.

1915d01

nits fixed.

12c43c4

fixes.

fb5acbc

fixes.

ada51b2

fixes

2648b0f

yasirfolio3 requested a review from jaeopt April 22, 2022 18:31

jaeopt requested changes Apr 22, 2022

View reviewed changes

yasirfolio3 added 3 commits April 25, 2022 12:58

suggested changes made.

97f59b3

fixing env issues

2adb67c

fixing env issues

baccced

yasirfolio3 requested a review from jaeopt April 25, 2022 09:11

jaeopt requested changes Apr 25, 2022

View reviewed changes

jaeopt requested changes Apr 26, 2022

View reviewed changes

suggested changes made.

6b83858

yasirfolio3 requested a review from jaeopt April 27, 2022 08:18

jaeopt approved these changes Apr 27, 2022

View reviewed changes

msohailhussain marked this pull request as ready for review April 28, 2022 20:47

msohailhussain requested a review from a team as a code owner April 28, 2022 20:47

msohailhussain approved these changes Apr 28, 2022

View reviewed changes

jaeopt merged commit df91547 into master Apr 28, 2022

jaeopt deleted the yasir/gitAction branch April 28, 2022 21:31

yasirfolio3 added a commit that referenced this pull request Mar 10, 2023

chore: removed travis yml and added git action support (#454)

b34c38a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: removed travis yml and added git action support #454

chore: removed travis yml and added git action support #454

yasirfolio3 commented Apr 14, 2022 •

edited

Loading

coveralls commented Apr 14, 2022 •

edited

Loading

msohailhussain Apr 19, 2022

yasirfolio3 Apr 20, 2022

msohailhussain Apr 26, 2022

msohailhussain Apr 19, 2022

jaeopt left a comment

jaeopt Apr 22, 2022

jaeopt Apr 22, 2022

jaeopt Apr 22, 2022

yasirfolio3 Apr 25, 2022

jaeopt Apr 22, 2022

yasirfolio3 Apr 25, 2022 •

edited

Loading

jaeopt Apr 22, 2022

yasirfolio3 Apr 25, 2022

jaeopt left a comment

yasirfolio3 commented Apr 26, 2022

jaeopt left a comment

jaeopt Apr 26, 2022

jaeopt left a comment

msohailhussain left a comment

		echo "SDK_BRANCH=${{ github.ref_name }}" >> $GITHUB_ENV
		echo "TRAVIS_BRANCH=${{ github.ref_name }}" >> $GITHUB_ENV

		#!/bin/bash -e
		set -e

chore: removed travis yml and added git action support #454

chore: removed travis yml and added git action support #454

Conversation

yasirfolio3 commented Apr 14, 2022 • edited Loading

Summary

Test plan

Result

NOTE

coveralls commented Apr 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaeopt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yasirfolio3 Apr 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaeopt left a comment

Choose a reason for hiding this comment

yasirfolio3 commented Apr 26, 2022

jaeopt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaeopt left a comment

Choose a reason for hiding this comment

msohailhussain left a comment

Choose a reason for hiding this comment

yasirfolio3 commented Apr 14, 2022 •

edited

Loading

coveralls commented Apr 14, 2022 •

edited

Loading

yasirfolio3 Apr 25, 2022 •

edited

Loading