Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-8918] chore: fix issues for prepare-release #495

Merged
merged 10 commits into from
Apr 28, 2023
Merged

Conversation

jaeopt
Copy link
Collaborator

@jaeopt jaeopt commented Apr 28, 2023

Summary

Fix issues for prepare-release

  • fix "hub pull-request" cli
  • remove run-test.sh from prep process

Issues

yasirfolio3
yasirfolio3 previously approved these changes Apr 28, 2023
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one query

@yasirfolio3 yasirfolio3 requested review from yasirfolio3 and removed request for yasirfolio3 April 28, 2023 19:27
@jaeopt jaeopt changed the title [DO NOT REVIEW] remove test_all from release script [FSSDK-8918] chore: fix issues for prepare-release Apr 28, 2023
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 6be8d9e into master Apr 28, 2023
@jaeopt jaeopt deleted the jae/fix-prep-2 branch April 28, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants