-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support intermediate value plots for constrained optimization #676
Support intermediate value plots for constrained optimization #676
Conversation
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage 62.88% 62.88%
=======================================
Files 35 35
Lines 2250 2250
=======================================
Hits 1415 1415
Misses 835 835 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@HideakiImamura Could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have a minor comment. PTAL.
? `trial #${trial.number}` | ||
: `trial #${trial.number} (running)`, | ||
name, | ||
...(!isFeasible && { line: { color: "#CCCCCC", dash: "dash" } }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment. I think that making dashed line of infeasible trials is very good.
I confirmed that the change of this PR produces the correct plot as follows. I used this code for verification. |
71fa843
to
9315b61
Compare
9315b61
to
634f959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
This PR intends to support PR#4851 in Optuna.
PR#4851 supported the gray coloring for infeasible solutions in the intermediate value plot.
Hence, I introduced the same feature to OptunaDashBoard.
Here is an example.
$ npm run build:dev $ optuna-dashboard sqlite:///$HOME/test.db
What does this implement/fix? Explain your changes.
#CCCCCC
,(infeasible)
if the trials are infeasible and complete.