Merge pull request #3517 from sbwalker/dev

suppress logging for resized image files which no longer exist
oqtane · Nov 29, 2023 · 73aca22 · 73aca22
2 parents c76946c + 077343c
commit 73aca22
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/Oqtane.Server/Controllers/FileController.cs b/Oqtane.Server/Controllers/FileController.cs
@@ -658,8 +658,15 @@ public IActionResult GetImage(int id, int width, int height, string mode, string
             }
             else
             {
-                _logger.Log(LogLevel.Error, this, LogFunction.Security, "Unauthorized File Access Attempt {FileId}", id);
-                HttpContext.Response.StatusCode = (int)HttpStatusCode.Forbidden;
+                if (file != null)
+                {
+                    _logger.Log(LogLevel.Error, this, LogFunction.Security, "Unauthorized File Access Attempt {FileId}", id);
+                    HttpContext.Response.StatusCode = (int)HttpStatusCode.Forbidden;
+                }
+                else
+                {
+                    HttpContext.Response.StatusCode = (int)HttpStatusCode.NotFound;
+                }
             }
 
             string errorPath = Path.Combine(GetFolderPath("wwwroot/images"), "error.png");