Translation - Header title in admin modules

[HoenesDK]

How do i get the header title in the Admin modules translated.
I have added the translations to SharedResources.da.resx, but header title is not translated.

[sbwalker]

@HonesDK #3117 should fix the issue you raised above... it appears that although the translations from SharedResources.resx were being used properly in the Admin Dashboard, the logic in the Module Title control was missing.

[sbwalker]

@leigh-pointer were you aware of this issue? I am just curious if I am missing something as I am surprised this has not been reported previously.

[leigh-pointer]

@sbwalker I wasnt aware. Seems strange how that slipped through! Are we sure that it has always been that way ?

[alikoli]

There is still an issue with section headings. For example Appearance is not taken from the resource, while all the properties (logo, etc) are translated correctly.

[sbwalker]

#3119 fixes the issue with the Section component. Note that keys need to be named ResourceKey.Heading

[alikoli]

So cool, now most translation issues are gone. With Appearance there is still an issue but in different place. I double checked if I have all current keys translated and went through Admin pages. Here are some issues I've found:

[alikoli]

And these are when I use edit current page:

[sbwalker]

@HonesDK thank you very much for identifying where localization issues exist. I do not believe that anyone has done a thorough localization review in recent releases, so it is not surprising that there are some missing keys, etc... The good news is that these are relatively simple issues to resolve - in fact @leigh-pointer has already addressed most of them in the past 12 hours - so they will be included in the upcoming 4.0.2 release.

[alikoli]

Let me know when they are fixed in a dev branch so I will verify all of them once again.

[sbwalker]

@alikoli they are now fixed in the Dev branch

[alikoli]

I confirm that some of the problems are solved. There is NullReferenceException on the Line:
public override string Title => Localizer["FolderManagement.Title"];
in oqtane.framework\Oqtane.Client\Modules\Admin\Files\Edit.razor
When I click EditFolder or AddFolder button. This problem is a new one, because I checked these buttons yesterday.

It looks like there are still some issues:

[sbwalker]

@leigh-pointer you cannot use the Localizer in this scenario as the Localizer service has not yet been instantiated. This throws a null reference. We will need to look through your recent PR to revert any of these changes.

    public override string Title => Localizer["FolderManagement.Title"];

[leigh-pointer]

@sbwalker there was only one! Fixed with new PR

[leigh-pointer]

@sbwalker I can fix this up for all (currently 8) places where the Module Title is overriden with the base.SetModuleTitle

base.SetModuleTitle(Localizer["FolderManagement.Title"]);

[sbwalker]

@leigh-pointer yes, please go ahead. I don't think you need to include the "base." as the method is inherited.

[alikoli]

I fixed some more issues with translation, could you merge my PR?

[alikoli]

Now this error is gone.
Edit folder:

Add folder:

This looks strange when part of the string is translated and the rest remain in english: