Fixed a bug where the caret / chevron was still displayed when a child page was deleted. #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd)" This reverts commit 0d10b51.
…d page was deleted. I also added HasNavigationChildren beside HasChildren to better support menus when you dont want the child pages visible in the menu. This will allow a page to have non-navigation children and not show the caret / chevron. The naming may need to change over time?
|
@Jayson-Furr can you please submit the menu changes as a separate PR from the module creator template? I have also noticed that the horizontal menu component is buggy. If I add a new page called Test which is a child of Home and specify navigation = true and add to end, the menu displays "Home Test Private ..." - which is incorrect. The menu should only display items at the current Level. The issue you raised is also a problem - where it is not ignoring Deleted pages - however I am not sure if a new property is necessary to fix the problem - I think the menu component is not interpreting the existing properties properly. |
|
Yes sir, I will re-fork it and get it this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the caret / chevron was still displayed when a child page was deleted. I also added HasNavigationChildren beside HasChildren to better support menus when you dont want the child pages visible in the menu. This will allow a page to have non-navigation children and not show the caret / chevron. The naming may need to change over time?