Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rows -> Maximum Records #1161

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Rows -> Maximum Records #1161

merged 2 commits into from
Mar 9, 2021

Conversation

hishamco
Copy link
Contributor

@hishamco hishamco commented Mar 5, 2021

Fixes #1152

thabaum
thabaum suggested changes Mar 6, 2021
View reviewed changes
Copy link
Contributor

@thabaum thabaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "Max Rows" be a better solution to utilize less screen space and still make it more clear?

@hishamco
Copy link
Contributor Author

hishamco commented Mar 6, 2021

I was thinking about that, before I push the PR ;)

@sbwalker
Copy link
Member

sbwalker commented Mar 8, 2021

It is the word "Rows" which is causing the confusion described in #1152 - that is why the suggestion was to change the label to "Maximum Records" so that it is clear that the dropdown has no correlation to the number of rows displayed on the screen.

@hishamco hishamco changed the title Rows -> Maximum Rows Rows -> Maximum Records Mar 8, 2021
@sbwalker sbwalker merged commit c9fa022 into oqtane:dev Mar 9, 2021
@hishamco hishamco deleted the fix#1152 branch March 9, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thabaum thabaum thabaum requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event log Rows Drop down not changing the number of rows displayed
3 participants
@hishamco @sbwalker @thabaum