Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude English from the languages list #1264

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

hishamco
Copy link
Contributor

No description provided.

@sbwalker
Copy link
Member

sbwalker commented Apr 21, 2021

I have a question about this PR. There is a fairly common scenario when it comes to localization where someone may want to customize the English resources. For example, they may want add additional clarification to the help text or error messages based on the knowledge level of their specific users. So in this case they would create a customized English translation and they would want to be able to install it and enable it within their site so that the system uses it rather than default static (English) text embedded in the application. Would this PR not make it impossible to do this?

@hishamco
Copy link
Contributor Author

This PR simply removes English from the list only, so whenever the user change the English translation he/she see the changes immediately after run the app

@sbwalker sbwalker merged commit 1088e9a into oqtane:dev Apr 23, 2021
@hishamco hishamco deleted the language-management-exculde branch April 25, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants