Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation of Language packages through Language Management #1318

Merged
merged 1 commit into from
May 5, 2021

Conversation

sbwalker
Copy link
Member

@sbwalker sbwalker commented May 5, 2021

No description provided.

@sbwalker sbwalker merged commit 6625fa7 into oqtane:dev May 5, 2021
@sbwalker
Copy link
Member Author

sbwalker commented May 5, 2021

@leigh-pointer I know you were experimenting with this already... but it would be great if you could test these enhancements. Basically you need to create a Nuget package which contains a satellite assembly... and then go to Language Management and choose Add Language and use the Upload tab to upload the Nuget package and then restart the application to complete the installation ( the satellite assembly should be placed in the subfolder under the /bin ).

@hishamco
Copy link
Contributor

hishamco commented May 5, 2021

This is good and bad from Security perspective, IMHO allow such thing from a TRUSTED source like NuGet.org much better, we can enter the package URL and the system will extract the language package

@hishamco
Copy link
Contributor

hishamco commented May 5, 2021

I think the intend is all the Oqtane translation should be hosted in Nuget to make it easier for developer to distribute the translatio resources

@sbwalker
Copy link
Member Author

sbwalker commented May 5, 2021

Yes it supports that as well... it offers exactly the same options as installing a module or theme. However there are no language packages on Nuget.org yet for Oqtane so the easier way to test this is to use the upload option.

@hishamco
Copy link
Contributor

hishamco commented May 6, 2021

However there are no language packages on Nuget.org yet for Oqtane

You are right, may it is useful for TESTING purpose but it harmful in production

@sbwalker
Copy link
Member Author

sbwalker commented May 6, 2021

@hishamco the upload option allows a host user to install a module, theme, or language package in their site at runtime ( usually a package that they developed for their own use and do not want to publish on Nuget ).

@leigh-pointer
Copy link
Contributor

@leigh-pointer I know you were experimenting with this already... but it would be great if you could test these enhancements. Basically you need to create a Nuget package which contains a satellite assembly... and then go to Language Management and choose Add Language and use the Upload tab to upload the Nuget package and then restart the application to complete the installation ( the satellite assembly should be placed in the subfolder under the /bin ).

Ok, I created a satellite assembly package and it installed with no problem. Unable to test the module at the moment due to oqtanes database issue.

@hishamco
Copy link
Contributor

hishamco commented May 6, 2021

I already reported the database issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants