Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing translation keys for module names #2232

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

ijaz-saeed
Copy link

without these keys, following module names are not translating,

image

@hishamco
Copy link
Contributor

hishamco commented Jun 6, 2022

Why you put them in shared resources?

@leigh-pointer
Copy link
Contributor

@hishamco I am guessing because all the other resources are in there in SharedResources.

@hishamco
Copy link
Contributor

hishamco commented Jun 6, 2022

I'm expecting ShareResources for that can be used in multiple places

@ijaz-saeed
Copy link
Author

Why you put them in shared resources?

as @leigh-pointer explained, all the other items in the image above are coming from ShareResources, so I put these there. But please let me know any other place and I will move it there. thanks @hishamco

@sbwalker
Copy link
Member

sbwalker commented Jun 6, 2022

SharedResources is the appropriate location for this information - because it is global

@hishamco
Copy link
Contributor

hishamco commented Jun 6, 2022

It's appropriate if we are using it in different places like Cancel, Delete ... etc, otherwise I suggest to move it to particular resource where it lives

@sbwalker
Copy link
Member

sbwalker commented Jun 6, 2022

Each site contains a default set of Administrative pages. The names of these Administrative pages as well as module titles on these pages use standard names such as "Site Settings" or "Page Management". When a user is interacting with the framework, they expect that these page names and module titles are displayed in their preferred language. The page names are displayed in the Admin Dashboard (ie. \Modules\Admin\Dashboard\Index.razor ). The module titles are displayed within a Container (ie. \Themes\Controls\Container\ModuleTitle.razor ). So the same localized strings are used in 2 different locations in the framework - so they belong in SharedResources.

@hishamco
Copy link
Contributor

hishamco commented Jun 6, 2022

Make sense

@sbwalker sbwalker merged commit 0b7c8e4 into oqtane:dev Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants