Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search refactoring #4388

Merged
merged 1 commit into from
Jul 6, 2024
Merged

search refactoring #4388

merged 1 commit into from
Jul 6, 2024

Conversation

sbwalker
Copy link
Member

@sbwalker sbwalker commented Jul 6, 2024

  • removed ISearchIndexManager extensibility (ISearchable should be the primary extensibility option)
  • removed methods with delegate parameters as they have poor encapsulation, have too much indirection, are difficult to understand and debug
  • fixed issue setting Alias when indexing
  • modified SearchIndexJob to handle pages, modules which implement ISearchable and modules which do not implement ISearchable
  • added support for reindexing when a parent object (ie. page or module) changes
  • indexed modules which appear on multiple pages (ie. unique urls)
  • improved performance by using PageModule.Page rather than calling GetPage()
  • made scheduled job, ISearchable interface, and SearchProvider methods async
  • ensured deleted content is purged from SearchContent
  • optimized ISearchable implementation in HtmlText module
  • replaced Utility IsPageModuleVisible with IsEffectiveOrExpired
  • created constant InternalPagePaths which is used by search indexer and site map generator

@sbwalker sbwalker merged commit a4eb3d7 into oqtane:dev Jul 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant