-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Microsoft.AspNetCore.Localization dependency #4774
Conversation
note this PR adds Microsoft.AspNetCore.Http which will need to be removed in a subsequent PR |
Is there a reason to remove it? |
@hishamco Microsoft.AspNetCore.Localization version 2.2.0 has been flagged as deprecated for quite some time (dotnet/announcements#217). In .NET 9 it is now flagged as containing a critical severity vulnerability:
System.Text.Encodings.Web is part of Microsoft.AspNetCore.Localization |
@hishamco Microsoft.AspNetCore.Http also contains System.Text.Encodings.Web as well so it has a similar problem in the upgrade to .NET 9. You can read more about it here: dotnet/aspnetcore#58593 |
Yes, I remembered that above announcement, but still a part of AspNetCore https://github.com/dotnet/aspnetcore/tree/main/src/Middleware/Localization/src I'm not sure why you are trying to implement |
@hishamco please read: dotnet/aspnetcore#58593 - it is not possible to access Microsoft.AspNetCore.App from within a Blazor Client project (ie. |
Maybe I didn't dig into the latest link, so can we add
Good to know that |
"can we add Oqtane.Localization project or namespace" I would prefer not to at this time as I am still exploring various solutions to try to avoid copying these classes into Oqtane |
Do you want me to try something? |
No description provided.