-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dashboard button/input table col size #628
Conversation
update master branch
…dashboard-table-col-size
I went ahead put two issues together since they relate to the same files. I am on the fence with the permissions grid component. I removed the space between the inputs so they are closer together which I like however I also like them closer to the name or role name. Something that can get discussed more later I can remove it and leave it as it was. Really 3 options presented above to choose from for any community feedback. If you like the Alternate way with the input closer to the name I can put that table-responsive class into the table to give it that effect. I just feel there needs to be a minimum width so the first row when users are selected line up the first View Edit... permissions together like when they are aligned to the right. During autocomplete fix... loaded the configuration file, then deleted it here in github thinking it would remove the changes, then had to re-add the file... bla bla bla. Let me know if I need to redo anything I know this keeps track of commits... hoping not a big deal maybe you have control over this in github? |
Summary
Fixes #627
and Fixes #601
Note: I also edited permissions table to put the inputs closer together. Putting a
table-responsive
class on the table will bring all of them close to the names/roles if desired. It just does not stretch out with the user input.I also edited the user input and grouped the items together so they are one as shown in the screenshot below for permissions.
Screenshots
Permission Grid Current Results in this PR:
![image](https://user-images.githubusercontent.com/13577556/85099684-ec00ec80-b1b2-11ea-8638-95a83e7696ab.png)
ALTERNATIVES
Adding Table-Responsive Class to Permission Grid Table
![image](https://user-images.githubusercontent.com/13577556/85099891-82cda900-b1b3-11ea-99be-b0faf85b7c33.png)
Personally I like adding the table responsive class to it however it does not use 100% of space with the user input area so not sure which to go with. Having them floating more to the left when a user is added the grids for user and roles are not lined up. I felt possibly adding some width to that table column header the same size as the Registered Users label field takes up plus a little extra which would resolve this look. And possibly adding a page line break to make UX clearer so that the User permission grid is more clearly visible.
Third option of coarse is to keep it as is.
I would like to at least keep the user input area grouping with an input-group class added to the row that includes the user input.
One last note on the spacing of the permission grid input check boxes is potentially making a class for it and wrap in a div
app-permission-grid
along with theapp-table-colfit
to address these. This can and I think should be done more when we focus on the responsiveness of the dashboard as well. If you like the PR as is you can merge it now. I am sorry the PR had a few mistakes in handling it's issues from things like uploading the configuration file... I can redo as desired.