Factored out Contants.*** Role into RoleNames.***

[TonyValenti]

Renamed 'AllUsers' to 'Everyone'

[dnfadmin]

All CLA requirements met.

[mikecasas]

I'm not against refactoring's like this, but it's going to break all my external modules. I know you included the Obsolete attribute.

If this is part of the movement to .NET 5, then I am ok with it.

My external controller code:

// GET api/<controller>/5
[HttpGet("{id}")]
[Authorize(Roles = Constants.RegisteredRole)]
public ReportViewer Get(int id)
{
  return _ReportViewers.GetReportViewer(id);
}

[TonyValenti]

@mikecasas What could I do different to make it not break?
Is it just breaking because it treats warnings as errors?

[mikecasas]

I meant it more in line that I would have to go and change all my modules - which I am not opposed to. It would be a simple find and replace.

I guess I just don't see the benefit - but that's me.

[hishamco]

The PR title is something and "Renamed 'AllUsers' to 'Everyone'" is another thing, could please filed an issue to describe the problem before you invest a time of something may not acceptable

Thanks

[sbwalker]

@mikecasas I am reviewing this PR and based on the fact that the current constants were not removed, I do not see where the breaking change is - are you able to explain? A breaking change is when your module throws a run-time error due to an incompatibility introduced in the framework. If what you are referring to is compilation warnings based on the Obsolete attributes it is not a breaking change as your module is still functional without any changes.

[mikecasas]

I mis-spoke, I should not have used the term breaking change.

[TonyValenti]

https://docs.microsoft.com/en-us/dotnet/core/compatibility/

This article has a good description of breaking changes. I don’t believe the changes I made are breaking.

Additionally, I would suggest adding the above article to the philosophy article and making that part of the official documentation in a markdown file.