Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request for apps-cloud-adventure-cio labs for Cloud World #417

Merged
merged 151 commits into from
Sep 7, 2024

Conversation

CDOracle
Copy link
Contributor

@CDOracle CDOracle commented Sep 6, 2024

11726

General requirements

  1. Information in the workshop is adequate and updated
  2. Code is correct and working
  3. Links are correct
  4. Make sure you enter the help email link in your manifest.json
  5. Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list

Please confirm that the following is completed before submitting your PR

  • [X ] All filenames are lower case (including folders, images, files, etc.)
  • [X ] Filenames are descriptive
  • [ X] Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
  • [X ] Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
  • [X ] Image references in markdown contain an alternate text

Copy link
Contributor

@klazarz klazarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CDOracle please change in all index.html files the URL developer.oracle.com/livelabs to livelabs.oracle.com

@klazarz klazarz merged commit b6e9d45 into oracle-livelabs:main Sep 7, 2024
streamnsight added a commit to streamnsight/oci that referenced this pull request Sep 20, 2024
* main:
  Updated screenshot removed tenancy (oracle-livelabs#420)
  Pull Request for apps-cloud-adventure-cio labs for Cloud World (oracle-livelabs#417)
  Opensearch Conversational Search Demo WMS 3427 (oracle-livelabs#418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants