Update default height calculation to bodyScroll (#20)

* Update default height calculation to bodyScroll
oracle-samples · Mar 22, 2018 · b793a6a · b793a6a
1 parent 1fddc27
commit b793a6a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 Next Release
 -------------
+1.4.0
+------
 * Added trigger for frame unloading. #18
+* Updated default height calucaltion to bodyScroll.
 
 1.3.2
 ------

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "xfc",
-  "version": "1.3.2",
+  "version": "1.4.0",
   "description": "A Cross Frame Container that handles securely embedding web content into a 3rd party domain",
   "author": "Cerner Corporation",
   "license": "Apache-2.0",

diff --git a/src/lib/dimension.js b/src/lib/dimension.js
@@ -49,7 +49,7 @@ const getWidth = {
   min: () => Math.min(...getAllMeasures(getWidth)),
 };
 
-export function calculateHeight(calMethod = 'max') {
+export function calculateHeight(calMethod = 'bodyScroll') {
   if (!(calMethod in getHeight)) {
     logger.error(`'${calMethod}' is not a valid method name!`);
   }