Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic options object to App init #46

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Add generic options object to App init #46

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c33a805
Add generic options object to App init
divyaashritha May 28, 2020
59a4ced
Release notes
divyaashritha Jun 2, 2020
c8de8e9
correct semver
divyaashritha Jun 2, 2020
9960e62
lock file
divyaashritha Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Next Release
-------------
1.8.2
------
* Add generic options object to App init. #46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be a 1.9 feature release. Also, we need README documentation on how to use this new feaature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update it.


1.8.1
------
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "xfc",
"version": "1.8.1",
"version": "1.8.2",
"description": "A Cross Frame Container that handles securely embedding web content into a 3rd party domain",
"author": "Cerner Corporation",
"license": "Apache-2.0",
Expand Down
2 changes: 2 additions & 0 deletions src/provider/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class Application extends EventEmitter {
* @param options.targetSelectors A DOMString containing one or more selectors to match against.
* This string must be a valid CSS selector string; if it's not,
* a SyntaxError exception is thrown.
* @param options.options An optional object used for App to transmit details to frame
* after App is authorized.
*/
init({ acls = [], secret = null, onReady = null, targetSelectors = '', options = {} }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation for this new parameter.

this.acls = [].concat(acls);
Expand Down