Add custom methods

[divyaashritha]

Summary

Add new CustomMethods object to init and invoke method for both App and frame.
App and frame can call these custom methods on each other and send information without having to explicitly have them declared in XFC.

[divyaashritha]

TODO: lint

[alex-bezek]

I know you were trying to just spread your customMethods object into the previous set of methods but it was giving you an unexpected token error like this

II think its due to this
esnext/es6-module-transpiler#111
https://stackoverflow.com/questions/10080551/weird-json-parsing-behavior-in-js-unexpected-token
Basically the existing { methods } isn't an object its a block with labels

Aetstetically all these extra const methods seem like noise, can you just do something like

const self = this;
this.JSONRPC = new JSONRPC(
    self.send,
    Object.assign(
        {
            launch() {
                self.wrapper.setAttribute('data-status', 'launched');
                self.emit('xfc.launched');
                return Promise.resolve();
            },

            authorized(detail = {}) {
                self.wrapper.setAttribute('data-status', 'authorized');
                self.emit('xfc.authorized', detail);
                self.initIframeResizer();
                return Promise.resolve();
            },

            unload(detail = {}) {
                self.wrapper.setAttribute('data-status', 'unloaded');
                self.emit('xfc.unload', detail);
                return Promise.resolve();
            },

            resize(height = null, width = null) {
                if (typeof resizeConfig.customCalculationMethod === 'function') {
                resizeConfig.customCalculationMethod.call(self.iframe);
                return Promise.resolve();
                }

                if (height) {
                self.iframe.style.height = height;
                }

                if (width) {
                self.iframe.style.width = width;
                }
                return Promise.resolve();
            },

            event(event, detail) {
                self.emit(event, detail);
                return Promise.resolve();
            },

            authorizeConsumer() {
                return Promise.resolve('hello');
            },

            challengeConsumer() {
                return Promise.resolve(self.secret);
            },

            loadPage(url) {
                self.load(url);
                return Promise.resolve();
            },
        },
        customMethods
    )
);

The syntax validator says it works and then if people add more methods they don't have to remember to add it to this object assign list

[divyaashritha]

sure, will update it!

[roxjcalderon]

Looks like the build is failing?

[mhemesath]

is there a test to ensure the custom methods are being setup correctly in JSONRPC?

[divyaashritha]

will update!

[divyaashritha]

@mhemesath updated!

[divyaashritha]

Using 1.9.0 as the change was not released