Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow k8s autoscaler to be installed via local terraform client, rather than remote operator. #894

Open
cwiggs opened this issue Feb 8, 2024 · 1 comment
Open

Allow k8s autoscaler to be installed via local terraform client, rather than remote operator. #894

cwiggs opened this issue Feb 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cwiggs
Copy link
Contributor

cwiggs commented Feb 8, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently the k8s autoscaler is installed via a remote-exec provisioner here. This works well if you are using the bastion and operator servers, but if you aren't using those servers you aren't able to deploy the autoscaler.

It would be nice to have a variable that allows you to install the autoscaler the same way but using the same machine where Terraform is running.

New or Affected Resource(s)

A variable in the autoscaler.tf file that allows you to use a local provisioner.

Questions

  • Currently The helm resource terraform provider is required and is used for a helm template with the autoscaler. However it then looks like instead of using the helm provider to install the helm package it's just applied via kubectl via remote provisioner. Is there a reason this isn't just done via the helm provider?

Thanks
@cwiggs cwiggs added the enhancement New feature or request label Feb 8, 2024
cwiggs added a commit to cwiggs/terraform-oci-oke that referenced this issue Feb 8, 2024
@cwiggs
feat: add autoscaler local exec option
4ca8249 
This commit adds the ability to deploy the k8s cluster autoscaler using
local-exec rather than remote-exec.  Using local-exec is helpful when
you don't use the operator/bastion features of this module.  Now if you
set cluster_autoscaler_remote_exec variable to false terraform will run
a `kubectl apply` command on the same machine where you are running
Terraform.

More info in this issue: oracle-terraform-modules#894

Signed-off-by: Chris Wiggins(5607419+cwiggs@users.noreply.github.com)
@cwiggs cwiggs mentioned this issue Feb 8, 2024
Open
@cwiggs
Copy link
Contributor Author

cwiggs commented Feb 8, 2024

I opened a draft PR to add this feature here: #895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwiggs