Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 5.x Evaluate subnets definition with omitted fields correctly #687

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix: 5.x Evaluate subnets definition with omitted fields correctly #687

merged 1 commit into from
Apr 5, 2023

Conversation

devoncrouse
Copy link
Contributor

Bug fix for evaluation of the subnets map - checking existence of key doesn't cover key present with null value.

@devoncrouse
fix: Evaluate subnets definition with omitted fields correctly
f8f1cbd 
Signed-off-by: Devon Crouse <devon.crouse@oracle.com>
@devoncrouse devoncrouse requested a review from hyder April 5, 2023 00:05
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 5, 2023
@devoncrouse devoncrouse changed the title fix: Evaluate subnets definition with omitted fields correctly fix: 5.x Evaluate subnets definition with omitted fields correctly Apr 5, 2023
hyder
hyder approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@hyder hyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

To do: Explicit control over subnetting using newbits and netnums and not to rely on contiguous network availability.

@devoncrouse devoncrouse merged commit a3ddc84 into oracle-terraform-modules:5.x Apr 5, 2023
@devoncrouse devoncrouse deleted the fix-subnet-check branch April 5, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyder hyder hyder approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devoncrouse @hyder